Undefined variables and indices

I'm new to Plogger but I like what I see, which is why I'm investigating further.

I have just installed it for the first time on a local server (easyphp) and I am getting a lot of errors on many of the pages. Most of the errors are in the form of "Undefined variable" or "Undefined index" errors.

I tried installing the latest download as well as running the head of SVN (http://svn.plogger.org/plogger/trunk) with similar results.

For example: I got this when loading plog-manage.php from the admin interface

Notice: Undefined variable: output in h:\www\plogger\admin\plog-admin-functions.php on line 1355

The fix was to add the following at the top of plog_collection_manager()

$output = "";

I am getting too many of these errors for this to be a typo or temporary problem. I wonder if there is some sort of server config that is different (though I would expect initializing variables would be a good thing).

Is there any interest in getting these resolved? I have started to fix some myself.

There are similar problems with indices but I'm not sure how to resolve those.

admin/plog-feedback.php
Notice: Undefined index: action in h:\www\plogger\admin\plog-feedback.php on line 39
Notice: Undefined index: action in h:\www\plogger\admin\plog-feedback.php on line 59

Oh, also, there appears to be a typo in generate_thumb(). There is a missing ) in the following if statement.
...
if (file_exists($thumbpath){
$thumbnail_timestamp = @filemtime($thumbpath);
if ($thumb_config['timestamp'] < $thumbnail_timestamp) {
return $thumburl;
}
}

Thanks, I figured out the error reporting issue, I found some other posts on similar issues. It turns out that easyphp has the php error level set to E_ALL instead of the default "E_ALL & ~E_NOTICE". I changed it and the messages went away.

However, it seems like these are valuable warnings that could be resolved with a few minor changes. They could be quite valuable at detecting typos in variable names. For example, the following (outpit .= "more output") would generate a warning if the variable outpit was never initialized. The way it is configured now, that line of code would not generate any warnings, but it would also not work correctly if you meant for that variable name to be "output".

None of the other apps I have tried running myself (wordpress and a few other gallery apps) have had any similar issues as this is the first time I even noticed how the php.ini was set.

I suggest that this is worth resolving in order to save a few confused user posts like mine (and a few others I've seen) and to help catch real errors that might occur in the code. If I continue to use plogger I may make the changes locally anyway, so I'm happy to contribute if anyone is interested.

I'm also new to plogger and have just downloaded and installed version 3 - look great.

I also get many PHP Notices for Undefined Variables & Undefined Index.

I hope this can be resolved in future realeases as agreed all variable should be defined. For now I guess I need to add: error_reporting(E_ALL); to your scripts.

Here are a couple more:

Plog_manage.php:
---------------------

From:

function generate_albums_menu($albums) {
$output .= '<select name="group_id">';


To

function generate_albums_menu($albums) {
$output = '<select name="group_id">';

From

function generate_move_menu($level) {

if ($level == "albums") $parent = "collections";

to

function generate_move_menu($level) {
$output = '';

if ($level == "albums") $parent = "collections";


plog_admin_functions.php
-------------------------------

from:
function plog_picture_manager($id,$from,$limit) {
plogger_init_pictures(array(
to:
function plog_picture_manager($id,$from,$limit) {
$output = '';
plogger_init_pictures(array(

Update admin/plog-upload.php:

function generate_albums_menu($albums) {
$output = '<select name="albums_menu" onclick="var k=document.getElementsByName(\'destination_radio\');k[0].checked=true;">';
foreach($albums as $album_id => $album) {

$selected = "";

// If we are on the current album then set it to be the default option
if (isset($_REQUEST["albums_menu"]) && isset($_REQUEST["new_album_name"]))
if ($_REQUEST["albums_menu"] == $album_id || $_REQUEST["new_album_name"] == $album['album_name'])
$selected = " selected='selected'";

$output .= "<option value=\"".$album_id."\"$selected>";
$output .= SmartStripSlashes($album['collection_name'])." : ".SmartStripSlashes($album['album_name'])."" ;
$output .= "</option>";
}

$output .= "</select>";

return $output;
}

Line 39 of admin/plog-feedback.php:

if (isset($_REQUEST['delete_checked']) || (isset($_REQUEST['action']) && $_REQUEST['action'] == 'delete_checked')) {

Line 238 of admin/plog-feedback.php:

$output .= "<td><p id=\"comment-$key-" . $row['id'] ."\">$value&nbsp;</p></td>";

plog-rss.php:

Change the end to. Line 133:

if (isset($query_parts["searchterms"])) {
generate_RSS_feed($level, $id, $query_parts["searchterms"]);
} else {
generate_RSS_feed($level, $id);
}

Line 35 of admin/plog-manage.php:

$output = '<input class="submit" type="submit" name="move_checked" value="' . plog_tr("Move Checked To") . '"/>';

FROM

$output .= '<input class="submit" type="submit" name="move_checked" value="' . plog_tr("Move Checked To") . '"/>';




Lines 1267-1268 of admin/plog-functions.php:

function plog_album_manager($id,$from,$limit) {
$output = '';

Small issue with the latest code from:

in plog-funtions.php, update the following methods:

function plogger_get_next_picture_link() {
$next_url = plogger_get_next_picture_url();
global $config;

if ($next_url)
if ($config["embedded"] == 0) {
$next_link = '<a id="next-button" accesskey="." href="'.$next_url.'#prev-button">' . plog_tr('Next') . ' &raquo;</a>';
} else {
$next_link = '<a id="next-button" accesskey="." href="'.$next_url.'">' . plog_tr('Next') . ' &raquo;</a>';
}
else
$next_link = '';

return $next_link;
}

function plogger_get_prev_picture_link() {
$prev_url = plogger_get_prev_picture_url();
global $config;

if ($prev_url)
if ($config["embedded"] == 0) {
$prev_link = '<a id="prev-button" accesskey="," href="'.$prev_url.'#next-button">&laquo; ' . plog_tr('Previous') . '</a>';
} else {
$prev_link = '<a id="prev-button" accesskey="," href="'.$prev_url.'">&laquo; ' . plog_tr('Previous') . '</a>';
}
else
$prev_link = '';

return $prev_link;


}

as they were missing the global $config; lines.

I added them all to the SVN trunk now (r536). Take a look, test, and see if any more show up. Thanks again for your help, MSummerville!

Nice! I've added the new missing index to my code (plus I found a few more on the RSS especially with mod_rewrite on). I'll wait until the end of the day to commit in case we find some more. That way I'll add them all at once.

ETA: I added all the additional instances I found plus yours to the SVN trunk (r538). I'll keep the ticket open in case we run into any other ones, but all the obvious ones that I could find are now fixed.