General Support: RSS and Photocasting

Hi there,

I'd like to use plogger for "Photocasting", Apple's new RSS hack for iPhoto. One can already do this with valid RSS feeds by setting up a Feedburner feed and using the feedburner feed as the Photocast URI. You don't get all of the functionality, but enough to keep Mom & Dad happy =).

One problem that I'm having with the RSS feed in Plogger is that it times out. My webserver is pretty fast. The problem is that my photos are fairly large, and I don't want to broadcast cropped images. I set the RSS thumbnail width to 2048, since that is the full size of the images, and the number of items to 100.

One solution to this problem would be if generate_thumb() did a check first to see if the image needs resizing before it goes ahead and runs it through GenerateThumbnail(). If the original image is the same size or smaller than the set thumbnail size, it should either copy the file as is to the /thumbs dir, or better yet, skip the I/O altogether and send a link to the original photo.

Thoughts?

It is indeed re-creating the thumbnails; no wonder its timing out. My webserver is running FreeBSD 5.4, apache 2.0.55_2, and mod_php 4.4.2_1,1 (ports). I have had some weird problems with php recently, where php's __FILE__ variable and basename() functions return relative paths, but everything seems to be working fine now.

The problem is likely in plog-functions.php here:

if (!file_exists($thumbpath) ||
                ($thumb_config['filename_prefix'] == '' && !$config['square_thumbs'] && $thumb_config['size'] != $height) ||
                ($thumb_config['filename_prefix'] == '' && !$config['square_thumbs'] && $width == $height) ||
                ($thumb_config['filename_prefix'] == '' && $config['square_thumbs'] && $width != $height) ||
                ($thumb_config['filename_prefix'] != '' && $thumb_config['size'] != $width) ||
                ($thumb_config['filename_prefix'] == '' && $config['square_thumbs'] && $thumb_config['size'] != $height && $thumb_config['size'] != $width))
 {
...

One of those conditions is returning true when it shouldn't.