Not signed in (Sign In)

Vanilla 1.1.10 is a product of Lussumo. More Information: Documentation, Community Support.

    • CommentAuthorarefsum
    • CommentTimeOct 7th 2008
     
    I have experienced "lost" albums and images problem several times on my test installation of plogger. This happens when I change the Description field of the containing collection. Looking at the database for the plogger_pictures table one can see that the path has been "lost" or messed up, ie there are no images specified any longer, only a partial and messed up path name. It is possible to go in manually into the database and fix the problem by fixing each path. This is a workable solution for a small amount of images, but for a large amount it is unworkable. (Should it not be image name, rather than path name?)

    I believe that using the whole complete path field a bit superfluous, as you basically only need the image name, parent_collection (id) and parent_album (id) since both are defined with path. If it is for speed, the it could have made sense, but otherwise it is not right.

    At the moment it is not really a problem for me, as I can fix the problem directly in the database, but when I let normal users have the solution I do not really want to have to do that.

    Another issue with the path solution you have chosen to implement is that there are no warnings when users define a new collection or album using characters that are not supported by the file system. Why don't you use "generated" internal names that are completely safe? Since it is all driven by a db engine anyway, you can just put the users defined name in a non active field. Renaming and moving stuff wouldn't then cause problems.

    Regards

    Alf
    •  
      CommentAuthorsidtheduck
    • CommentTimeOct 7th 2008
     
    arefsum, thanks for letting us know of this issue. However, I have a couple of question of my own and some responses / answers for other questions of yours.

    Posted By: arefsumI have experienced "lost" albums and images problem several times on my test installation of plogger. This happens when I change the Description field of the containing collection.
    Do you have any special characters or anything that you are adding to the description field (double or single quotes, especially?). There may have been a bug regarding not escaping quotes in the description. I believe this has been fixed in the current codebase, but I will check. It should be resolved in the next release of Plogger.

    Posted By: arefsumie there are no images specified any longer, only a partial and messed up path name
    Can you describe an example of the description you enter and the resulting path change in the db? I'm just trying to verify if my assumption above is correct or not and I may be able to verify that if you give an example. Also, is this if you edit the description using the AJAX editing or the form edit (editing the description in place or clicking the little pencil icon to the right)?

    Posted By: arefsumI believe that using the whole complete path field a bit superfluous, as you basically only need the image name, parent_collection (id) and parent_album (id) since both are defined with path. If it is for speed, the it could have made sense, but otherwise it is not right.
    This does help speed things up, but also helps greatly with the Cruft Free URL option (i.e. www.yoursite.com/plogger/collection-name/album-name/image-name).

    Posted By: arefsumWhy don't you use "generated" internal names that are completely safe?
    Actually, there were measures in place to try to make safe path names (the sanitize_filename function). However, I did notice a few spots where this was not being used correctly in the beta3 release. I think I have caught all the erroneous locations and updated the sanitize_filename to work better with many different types of filenames. The next release has fixed quite a few bugs that have come up during the long testing process that Plogger beta3 has undergone. :D

    Please let us know of any additional bugs that you come across as well!
    • CommentAuthorarefsum
    • CommentTimeOct 7th 2008
     
    sidtheduck, thanks for answering and taking care of this issue. I am happy that is / will be sorted out, and have the time to wait for the next release. Anyway, I try will to answer your questions.

    Posted By: sidtheduckDo you have any special characters or anything that you are adding to the description field (double or single quotes, especially?). There may have been a bug regarding not escaping quotes in the description. I believe this has been fixed in the current codebase, but I will check. It should be resolved in the next release of Plogger.

    On some there were definitively single quotes and a acutes. Like in Al-Dahna's (where the last a is an aacute). I used those in the descriptive field. (First tried in collect and album names, but found out the did not work very well ;-)

    Posted By: sidtheduckCan you describe an example of the description you enter and the resulting path change in the db? I'm just trying to verify if my assumption above is correct or not and I may be able to verify that if you give an example. Also, is this if you edit the description using the AJAX editing or the form edit (editing the description in place or clicking the little pencil icon to the right)?

    Using the edit form I changed the collection description from "Galleries of individual Kennel Al-Dahná dogs" to "Galleries of individual Al-Dahná dogs". 3 albums and their pictures disappeared. The path in the pictures table should have been like this: "individual_kennel_al-dahna/hippi/hippi_og_sesto.jpg" but ended up like this: "individual_kennel_al-dahn". This also happened when I set the album image using the edit form.


    Posted By: sidtheduckThis does help speed things up, but also helps greatly with the Cruft Free URL option (i.e. www.yoursite.com/plogger/collection-name/album-name/image-name).
    No problem. I am using plogger embedded in fashion, so not all that interested in the Cruft Free URL option. I think the drawback currently is that it can be very difficult to recreate the full path and image name without looking at the EXIF info for each image when it is accidentally corrupted.

    Posted By: sidtheduckActually, there were measures in place to try to make safe path names (the sanitize_filename function). However, I did notice a few spots where this was not being used correctly in the beta3 release. I think I have caught all the erroneous locations and updated the sanitize_filename to work better with many different types of filenames. The next release has fixed quite a few bugs that have come up during the long testing process that Plogger beta3 has undergone. :D
    Cool :-)

    BTW: Is there any place on the site where you have a link to the lastest (semi) working SVN copy of plogger?

    Regards

    Alf